chore(deps): import resty.mlcache from lua-resty-mlcache #10989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
force-pushed
the
chore/import-mlcache
branch
2 times, most recently
from
0e1dd61 to
75e1827
Compare
bungle
changed the title
bungle
changed the title
bungle
force-pushed
the
chore/import-mlcache
branch
2 times, most recently
from
76f3e39 to
64fe003
Compare
hanshuebner
approved these changes
Jun 1, 2023
|
@bungle CI stays red after retry, related? |
bungle
force-pushed
the
chore/import-mlcache
branch
from
64fe003 to
23e18ce
Compare
not related. now green. there seems to be some newly introduced flakiness. |
bungle
force-pushed
the
chore/import-mlcache
branch
from
23e18ce to
c2b73b7
Compare
@hanshuebner, now it is related as it now runs the tests because of: I'll fix the mlcache tests. |
bungle
force-pushed
the
chore/import-mlcache
branch
from
c2b73b7 to
fc6e0c2
Compare
hanshuebner
previously approved these changes
Jun 2, 2023
### Summary Forking `resty.mlcache` into Kong in preparations on adding functionality and changes to it that are out of the scope for the upstream project. Co-authored-by: Thibault Charbonnier<thibaultcha@me.com> (@thibaultcha) Co-authored-by: Thijs Schreijer<thijs@thijsschreijer.nl> (@Tieske) Co-authored-by: Julien Desgats(@jdesgats) Co-authored-by: Robert Paprocki<robert@cryptobells.com> (@p0pr0ck5) Co-authored-by: Aapo Talvensaari<aapo.talvensaari@gmail.com> (@bungle) Co-authored-by: Chrono Law<chrono_cpp@me.com> (@chronolaw) Co-authored-by: Michael Martin<flrgh@protonmail.com> (@flrgh) Co-authored-by: Hamish Forbes (@hamishforbes) Co-authored-by: Piotr Przybylski<piotrprz@gmail.com> (@piotrp) Co-authored-by: Martin Amps<m@rtin.so> (@martinamps) Co-authored-by: Yuchen Wu<eaufavor@gmail.com> (@eaufavor) Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
### Summary With Kong we will run tests with known OpenResty version, so we can remove some mlcache tests that were for older OpenResty versions and also the usage of `skip_openresty` clauses. Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
force-pushed
the
chore/import-mlcache
branch
from
16ba759 to
a9624fb
Compare
…lcache lib Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
force-pushed
the
chore/import-mlcache
branch
from
a9624fb to
a6dc798
Compare
hanshuebner
approved these changes
Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Forking
resty.mlcacheinto Kong in preparations on adding functionality and changes to it that are out of the scope for the upstream project. Some of which we may try to contribute to upstream too.